Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch testing to GitHub Actions #14

Merged
merged 10 commits into from
Mar 4, 2021
Merged

Switch testing to GitHub Actions #14

merged 10 commits into from
Mar 4, 2021

Conversation

agitter
Copy link
Member

@agitter agitter commented Feb 24, 2021

This initially attempts to run the tests on Linux, macOS, and Windows. If there are errors, we can drop one or more of those.

If GitHub Actions runs successfully, I'll disable the Travis CI tests.

@agitter
Copy link
Member Author

agitter commented Feb 24, 2021 •
edited
Loading

Windows builds failed so I disabled them. Specifically, compiling PGD failed. We can inspect the build log if we want to support Windows in the future. However, the PGD readme says it does not support Windows.

The macOS build currently fails as well:

g++-5 -O3  -fopenmp -ffast-math -funroll-loops -fno-strict-aliasing -fomit-frame-pointer -fexpensive-optimizations -funroll-loops -fmove-loop-invariants -fprefetch-loop-arrays -ftree-loop-optimize -ftree-vect-loop-version -ftree-vectorize -c graphlet_driver.cpp
In file included from /usr/local/Cellar/gcc@5/5.5.0_6/include/c++/5.5.0/bits/postypes.h:40:0,
                 from /usr/local/Cellar/gcc@5/5.5.0_6/include/c++/5.5.0/iosfwd:40,
                 from /usr/local/Cellar/gcc@5/5.5.0_6/include/c++/5.5.0/ios:38,
                 from /usr/local/Cellar/gcc@5/5.5.0_6/include/c++/5.5.0/ostream:38,
                 from /usr/local/Cellar/gcc@5/5.5.0_6/include/c++/5.5.0/iostream:39,
                 from graphlet_headers.h:36,
                 from graphlet.h:36,
                 from graphlet_driver.cpp:48:
/usr/local/Cellar/gcc@5/5.5.0_6/include/c++/5.5.0/cwchar:44:19: fatal error: wchar.h: No such file or directory
compilation terminated.
make: *** [graphlet_driver.o] Error 1

We should see what is causing that error. It could be the macOS version.
Travis CI:

Operating System Details
ProductName:	Mac OS X
ProductVersion:	10.13.6
BuildVersion:	17G65

GitHub Actions:

Operating System
  Mac OS X
  10.15.7
  19H512

@agitter agitter requested a review from csmagnano February 25, 2021 15:27
@agitter agitter merged commit fa7aebe into master Mar 4, 2021
@agitter agitter deleted the github-actions branch March 4, 2021 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csmagnano csmagnano Awaiting requested review from csmagnano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@agitter